Preprocess the dataframe X to remove newlines#430
Merged
Conversation
tramora
force-pushed
the
413-multi-line-fields-in-dataframes
branch
from
743360d to
6a84438
Compare
popescu-v
reviewed
Jul 7, 2025
popescu-v
reviewed
Jul 7, 2025
popescu-v
reviewed
Jul 7, 2025
popescu-v
reviewed
Jul 7, 2025
popescu-v
reviewed
Jul 7, 2025
popescu-v
reviewed
Jul 7, 2025
popescu-v
requested changes
Jul 7, 2025
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
Some minor issues (see the comments).
tramora
force-pushed
the
413-multi-line-fields-in-dataframes
branch
from
6a84438 to
d9d7363
Compare
popescu-v
requested changes
Jul 8, 2025
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
One remaining doc comment.
…ewlines To avoid any code duplication, the best place to perform the preprocessing is just before handing over to Khiops (when writing the csv file)
tramora
force-pushed
the
413-multi-line-fields-in-dataframes
branch
from
d9d7363 to
3675d28
Compare
popescu-v
reviewed
Jul 9, 2025
| so that Khiops can handle them. | ||
| Hence, multi-line records are preprocessed: | ||
| carriage returns / line feeds are replaced | ||
| with blank spaces before being handed over to Khiops. |
Collaborator
There was a problem hiding this comment.
Add:
A memory penalty is incurred, as a new dataframe is generated following the preprocessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #413
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html